Fix printing internal libs with the command "dune describe external-lib-deps" #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyodiallo
force-pushed
the
fix-bug-external-lib-dpes
branch
from
4f62fc7 to
12b2716
Compare
|
It would really help understanding your fix if you could give an example that first shows the produced output and the expected output, and explains why the expected output should be the right one. |
|
This PR refers to #6045 |
|
This was the print before. and the right one is This is because Refer to the tests that I added. |
|
Is it possible to have this PR for dune 3.6 ? |
moyodiallo
force-pushed
the
fix-bug-external-lib-dpes
branch
from
a5a7ee6 to
bc3b000
Compare
emillon
reviewed
Nov 8, 2022
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/dune-project
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/lib/dune
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/external-lib-deps/fix-bug.t/run.t
Outdated
Show resolved
Hide resolved
moyodiallo
force-pushed
the
fix-bug-external-lib-dpes
branch
from
e46e743 to
5758050
Compare
When the internal libs are added as dependency by another dune library or dune executable. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
emillon
force-pushed
the
fix-bug-external-lib-dpes
branch
from
b428c19 to
99c7002
Compare
|
Thanks! |
emillon
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the internal libs are added as dependency by another dune library or dune executable, those are printed.